adutra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2725714302
##########
aws/src/test/java/org/apache/iceberg/aws/TestS3FileIOProperties.java:
##########
@@ -225,7 +225,12 @@ public void testS3RemoteSigningEnabled() {
String uri = "http://localhost:12345";;
Map<String, String> properties =
ImmutableMap.of(
- S3FileIOProperties.REMOTE_SIGNING_ENABLED, "true",
CatalogProperties.URI, uri);
+ S3FileIOProperties.REMOTE_SIGNING_ENABLED,
+ "true",
+ CatalogProperties.URI,
+ uri,
+ CatalogProperties.SIGNER_ENDPOINT,
Review Comment:
For now it's not required, but it will become required in a future release
(1.12 or later).
There is a check + warning here:
https://github.com/adutra/iceberg/blob/f3fc09595bc47d4f0ba7a879d3c7eaf3d70c1e38/aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java#L219-L224
I proactively updated the tests so that they don't break when we make this
property required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
