nastra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2726637512
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -94,13 +112,15 @@ public Supplier<Map<String, String>>
requestPropertiesSupplier() {
@Value.Lazy
public String baseSignerUri() {
- return properties().getOrDefault(S3_SIGNER_URI,
properties().get(CatalogProperties.URI));
+ return properties()
+ .getOrDefault(CatalogProperties.SIGNER_URI,
properties().get(CatalogProperties.URI));
Review Comment:
my comment was about the fact that the old `s3.signer.*` property wasn't
read anymore in your initial version of the PR because `S3_SIGNER_URI` was
pointing to a different property, which was a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
