danielcweeks commented on code in PR #15283:
URL: https://github.com/apache/iceberg/pull/15283#discussion_r2790104452
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -464,6 +474,119 @@ protected Temporal convertTimestampValue(Object value,
TimestampType type) {
return convertLocalDateTime(value);
}
+ protected Variant convertVariantValue(Object value) {
Review Comment:
If we're recursing through the schema/object structure, we don't assume the
need to protect against stack overflow (either you can traverse the structure
or not). I guess there may be some way to construct an object that will cycle,
but that's not typical with how the object mapping works in kafka (it would
probably fail upstream of this point anyway).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
