danielcweeks commented on code in PR #15283:
URL: https://github.com/apache/iceberg/pull/15283#discussion_r2790234018
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -464,6 +474,119 @@ protected Temporal convertTimestampValue(Object value,
TimestampType type) {
return convertLocalDateTime(value);
}
+ protected Variant convertVariantValue(Object value) {
+ if (value instanceof Variant) {
Review Comment:
This isn't necessarily wrong, but I'm not clear on why we would be receiving
a variant type. The supported Kafka key/value mappers don't produce Iceberg
vaiant as a type, so this would be unexpected to see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
