danielcweeks commented on code in PR #15283:
URL: https://github.com/apache/iceberg/pull/15283#discussion_r2790249881
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -464,6 +474,119 @@ protected Temporal convertTimestampValue(Object value,
TimestampType type) {
return convertLocalDateTime(value);
}
+ protected Variant convertVariantValue(Object value) {
+ if (value instanceof Variant) {
+ return (Variant) value;
+ } else if (value instanceof ByteBuffer) {
+ return Variant.from((ByteBuffer) value);
+ }
+
+ List<String> allFieldNames =
+
collectFieldNames(value).stream().distinct().sorted().collect(Collectors.toList());
+ VariantMetadata metadata =
+ allFieldNames.isEmpty() ? Variants.emptyMetadata() :
Variants.metadata(allFieldNames);
+ VariantValue variantValue = objectToVariantValue(value, metadata);
+ return Variant.of(metadata, variantValue);
+ }
+
+ /**
+ * Collects all field names (map keys) from the entire object tree. Used to
build a single
+ * VariantMetadata for the whole Variant (required for nested maps).
+ */
+ private static List<String> collectFieldNames(Object value) {
Review Comment:
+1 to @emkornfield's comment. We should avoid navigating the object
multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
