seokyun-ha-toss commented on code in PR #15283:
URL: https://github.com/apache/iceberg/pull/15283#discussion_r2793674151
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -464,6 +474,119 @@ protected Temporal convertTimestampValue(Object value,
TimestampType type) {
return convertLocalDateTime(value);
}
+ protected Variant convertVariantValue(Object value) {
Review Comment:
Good point. However, as @danielcweeks mentioned, actual Kafka values don't
have cycles, so the recursion ends at some point.
In my opinion, the stack overflow concern is unavoidable when traversing
arbitrarily nested values. It depends on the size and depth of the input data,
and in many cases we cannot control it.
Also, some methods (`convertValue()`, `convertStructValue()`,
`convertListValue()`) already work recursively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
