dramaticlly commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2891431406
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -59,7 +59,7 @@
public class BaseTransaction implements Transaction {
private static final Logger LOG =
LoggerFactory.getLogger(BaseTransaction.class);
- enum TransactionType {
+ protected enum TransactionType {
Review Comment:
@deniskuzZ yeah I think here's the context
https://github.com/apache/iceberg/pull/13631#discussion_r2237931079
a factory class only help with instantiation, existing package-private
constructor still requires the subclass to live in the same
`org.apache.iceberg` package in order to call its parent constructor.
Since this is being asked more than once, @rdblue do you think we can take
this opportunity to make it protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
