deniskuzZ commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2886355439
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -59,7 +59,7 @@
public class BaseTransaction implements Transaction {
private static final Logger LOG =
LoggerFactory.getLogger(BaseTransaction.class);
- enum TransactionType {
+ protected enum TransactionType {
Review Comment:
@dramaticlly, you made a similar change in
https://github.com/apache/iceberg/pull/13631/files, so I’m not sure why a
similar request is being questioned now.
https://github.com/apache/iceberg/pull/15389#discussion_r2886355439
````
We realized some difficulties to extend the BaseTransactions
// methods made protected to support extensibility in subclasses//
//
// Protected final methods available for subclasses:
// - appendUpdates(PendingUpdate): adds operations to transaction and apply
essential chores
//
// Example usage in a subclass:
private static class CustomTransaction extends BaseTransaction {
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
