dramaticlly commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2880925963
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -59,7 +59,7 @@
public class BaseTransaction implements Transaction {
private static final Logger LOG =
LoggerFactory.getLogger(BaseTransaction.class);
- enum TransactionType {
+ protected enum TransactionType {
Review Comment:
Kind of in the similar boat before, but do we really need this or we can use
a public factory to vend out the transactions like in
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/Transactions.java?
If so, we can leave the enum and constructor to be package private as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
