deniskuzZ commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2880968785
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -59,7 +59,7 @@
public class BaseTransaction implements Transaction {
private static final Logger LOG =
LoggerFactory.getLogger(BaseTransaction.class);
- enum TransactionType {
+ protected enum TransactionType {
Review Comment:
Which factory are you referring to? I want to override `BaseTransaction` to
add support for staged multi-table commits.
What’s the point of making `cleanUp` protected in that case? How am I
supposed to invoke it?
We could keep the enum package-private, but in that case, we’d need a
default constructor that sets transactionType to `SIMPLE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
