yyanyy opened a new pull request #1820: URL: https://github.com/apache/iceberg/pull/1820
- Please see [this comment](https://github.com/apache/iceberg/pull/1803#discussion_r528061128_) for the reason to have this change - Please note that this changes the behavior of `recordCount` in `BaseFile`; originally if `BaseFile` was created by avro schema reflection without populating `recordCount`, calling `recordCount()` will throw NPE because its return type is primitive. I'm currently following the same style as `fileSizeInBytes` to return -1 when it is not populated. - One implication of this is that the NPE problem described in the original comment will no longer exist, instead metrics evaluators will not filter out anything. - Alternatively I can refrain from changing this and accept that `data.recordCount()` could throw NPE in tests, or change the return type of `recordCount()` to be `Long`; I don't really have a strong preference so suggestions are welcome! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
