yyanyy commented on a change in pull request #1820:
URL: https://github.com/apache/iceberg/pull/1820#discussion_r530610375
##########
File path: core/src/main/java/org/apache/iceberg/ManifestReader.java
##########
@@ -289,12 +296,12 @@ static boolean dropStats(Expression rowFilter,
Collection<String> columns) {
Sets.intersection(Sets.newHashSet(columns), STATS_COLUMNS).isEmpty();
}
- private static Collection<String> withStatsColumns(Collection<String>
columns) {
+ static Collection<String> withStatsColumns(Collection<String> columns) {
Review comment:
In one of the usage `columns` directly comes from [the field `column`
which is a
collection](https://github.com/apache/iceberg/blob/b1296bcbe8e050d4bc28e3d41feb2f8868c8f0bf/core/src/main/java/org/apache/iceberg/ManifestReader.java#L84)
so I didn't change that, but it seems that from all its current usage this
field could be changed to a list. I'll need to update a few tests after this
but I think it's doable. Will do!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
