rdblue commented on a change in pull request #1820:
URL: https://github.com/apache/iceberg/pull/1820#discussion_r536924735
##########
File path: core/src/main/java/org/apache/iceberg/ManifestReader.java
##########
@@ -52,8 +54,13 @@
public class ManifestReader<F extends ContentFile<F>>
extends CloseableGroup implements CloseableIterable<F> {
static final ImmutableList<String> ALL_COLUMNS = ImmutableList.of("*");
- static final Set<String> STATS_COLUMNS = Sets.newHashSet(
+
+ // the difference between the two stats set below is to support
ContentFile.copyWithoutStats(), which
+ // still keeps record count.
+ private static final Set<String> STATS_COLUMNS = Sets.newHashSet(
Review comment:
Can we special-case `record_count`? I don't think that `record_count`
should be dropped in `copyWithoutStats`, but I also agree that simply selecting
`record_count` should not select all stats columns.
This set is primarily for ensuring that all stats required to filter the
instances of `DataFile` or `DeleteFile` stored in a manifest are present. I
think we should limit it to that purpose. I don't think that this list should
affect the behavior or `copyWithoutStats`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
