rdblue commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2934021512
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTScanPlanning.java:
##########
@@ -922,12 +922,11 @@ public void serverSupportsPlanningButNotPagination() {
setParserContext(table);
RESTTableScan scan = restTableScanFor(table);
- // Should fail with UnsupportedOperationException when trying to fetch
paginated tasks
- // because V1_FETCH_TABLE_SCAN_PLAN_TASKS endpoint is not supported
+ // Should fail with IllegalStateException when trying to fetch paginated
tasks
+ // because the server does not support fetching scan tasks
assertThatThrownBy(scan::planFiles)
- .isInstanceOf(UnsupportedOperationException.class)
- .hasMessage(
- "Server does not support endpoint: %s",
Endpoint.V1_FETCH_TABLE_SCAN_PLAN_TASKS);
+ .isInstanceOf(IllegalStateException.class)
+ .hasMessage("Server returned plan tasks but does not support fetching
scan tasks");
Review Comment:
What about "Cannot fetch scan tasks for plan {}: service does not support
fetch"? Ideally we would just fail before attempting to plan though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
