rdblue commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2933987839
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -598,6 +598,9 @@ private RESTTable restTableForScanPlanning(
TableOperations ops, TableIdentifier finalIdentifier, RESTClient
restClient) {
// server supports remote planning endpoint and server / client wants to
do server side planning
if (endpoints.contains(Endpoint.V1_SUBMIT_TABLE_SCAN_PLAN) &&
restScanPlanningEnabled) {
+ boolean supportsAsync =
endpoints.contains(Endpoint.V1_FETCH_TABLE_SCAN_PLAN);
Review Comment:
Another concern here is that we don't want people to think that a reasonable
implementation may use the async endpoint to plan an entire scan and send it
back as one result, rather than breaking up the planning operation and using
multiple calls to fetch the results. That would be a really bad use of this API
and is another good reason to make fetch required and async optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
