rdblue commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2934005199
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -90,44 +78,30 @@ class RESTTableScan extends DataTableScan {
Schema schema,
TableScanContext context,
RESTClient client,
- Map<String, String> headers,
- TableOperations operations,
- TableIdentifier tableIdentifier,
- ResourcePaths resourcePaths,
- Set<Endpoint> supportedEndpoints,
- Map<String, String> catalogProperties,
- Object hadoopConf) {
+ Supplier<Map<String, String>> headers,
+ RESTScanContext scanContext) {
super(table, schema, context);
this.client = client;
this.headers = headers;
- this.operations = operations;
- this.tableIdentifier = tableIdentifier;
- this.resourcePaths = resourcePaths;
- this.supportedEndpoints = supportedEndpoints;
- this.parserContext =
- ParserContext.builder()
- .add("specsById", table.specs())
- .add("caseSensitive", context().caseSensitive())
- .build();
- this.catalogProperties = catalogProperties;
- this.hadoopConf = hadoopConf;
+ this.scanContext = scanContext;
+ }
+
+ private ParserContext parserContext() {
Review Comment:
`lazyParserContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
