nastra commented on code in PR #15595:
URL: https://github.com/apache/iceberg/pull/15595#discussion_r2939813674
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -74,16 +71,15 @@ class RESTTableScan extends DataTableScan {
.build();
private final RESTClient client;
- private final Map<String, String> headers;
- private final TableOperations operations;
- private final Table table;
- private final ResourcePaths resourcePaths;
- private final TableIdentifier tableIdentifier;
- private final Set<Endpoint> supportedEndpoints;
+ private final Supplier<Map<String, String>> headers;
+ private final String planTableScanPath;
+ private final Function<String, String> planPath;
+ private final String fetchScanTasksPath;
+ private final boolean supportsAsync;
+ private final boolean supportsCancel;
+ private final boolean supportsFetchTasks;
Review Comment:
> @nastra, this doesn't mean the fetch endpoint actually has to do anything.
You could always return all results from plan and avoid hitting it. But we
don't need to increase the complexity of all clients.
@rdblue I believe this should be acceptable for implementors as long as we
clearly document the requirements, so I'm in favor of doing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
