danielcweeks commented on a change in pull request #1844:
URL: https://github.com/apache/iceberg/pull/1844#discussion_r533590527
##########
File path: api/src/main/java/org/apache/iceberg/io/FileIO.java
##########
@@ -20,7 +20,7 @@
package org.apache.iceberg.io;
import java.io.Serializable;
-import java.util.Map;
+import org.apache.iceberg.catalog.CatalogConfigurable;
Review comment:
@rdblue, one thing we need to think about is how we want to pass
properties down. I feel like CatalogConfigurable is a bit of a misnomer here
because we should really be able to specify properties at a Catalog level or a
table level (e.g. someone may want to configure table specific credentials that
differ from the catalog).
How these properties are accessed and cascade is somewhat unclear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
