danielcweeks commented on a change in pull request #1844: URL: https://github.com/apache/iceberg/pull/1844#discussion_r533764793
########## File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientCredentialsFactory.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws; + +import java.io.Serializable; +import org.apache.iceberg.catalog.CatalogConfigurable; +import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder; + +/** + * Interface for loading a custom factory to configure AWS credentials for different services. + * See {@link AssumeRoleCredentialsFactory} as an example. Review comment: @jackye1995 I'm not proposing that users would subclass the S3FileIO, but rather that we take your approach of dynamically loading and just up-level it to the whole S3Client supplier as opposed to just parts of the client configuration. This would mean configuring with something like `--conf spark.sql.catalog.my_catalog.client.s3.supplier=com.my.team.S3ClientSupplier`. We could then just change the S3FileIO to check for a configured supplier before using the default client. This allows anyone to supply a fully configured client based on their own requirements and we wouldn't need to expose the specific configurations through the Iceberg APIs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
