jackye1995 commented on a change in pull request #1844: URL: https://github.com/apache/iceberg/pull/1844#discussion_r533637419
########## File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientCredentialsFactory.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws; + +import java.io.Serializable; +import org.apache.iceberg.catalog.CatalogConfigurable; +import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder; + +/** + * Interface for loading a custom factory to configure AWS credentials for different services. + * See {@link AssumeRoleCredentialsFactory} as an example. Review comment: This PR mostly comes from the following use cases: 1. use a customized credential provider across all the AWS clients 2. use some kind of proxy configuration for HTTP client to bypass network boundary (not included in this PR, plan to put in another one) I completely agree that we should expose limited number of configurations for S3FileIO, but those are not related to S3 but AWS clients in general. And maybe I missed something, but based on my understanding, for people using open source Iceberg directly, it is not straightforward to use the supplier, unless they do something like ```java public MyS3ClientFileIO extends S3FileIO { public MyS3ClientFileIO() { super(new MyS3ClientSupplier()); } } ``` And load the `MyS3ClientFileIO` instead of `S3FileIO` as the FileIO implementation, which is (1) not very convenient, and (2) people with the requirements I listed basically have to override all the classes that touches AWS clients. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
