jackye1995 commented on a change in pull request #1844:
URL: https://github.com/apache/iceberg/pull/1844#discussion_r533891357
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -37,12 +37,16 @@
* See {@link S3URI#VALID_SCHEMES} for the list of supported S3 URI schemes.
*/
public class S3FileIO implements FileIO {
- private final SerializableSupplier<S3Client> s3;
+ private SerializableSupplier<S3Client> s3;
private AwsProperties awsProperties;
private transient S3Client client;
+ /**
+ * No-arg constructor to load the FileIO dynamically.
+ * <p>
+ * All fields are initialized by calling {@link S3FileIO#initialize(Map)}
later.
+ */
public S3FileIO() {
- this(AwsClientUtil::defaultS3Client);
}
public S3FileIO(SerializableSupplier<S3Client> s3) {
Review comment:
Yes this constructor should not call initialize, currently within
Iceberg it is only used by tests. Let me add the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
