nastra commented on code in PR #16611:
URL: https://github.com/apache/iceberg/pull/16611#discussion_r3324992815
##########
core/src/main/java/org/apache/iceberg/formats/FormatModelRegistry.java:
##########
@@ -205,7 +205,7 @@ private static void registerSupportedFormats() {
for (String classToRegister : CLASSES_TO_REGISTER) {
try {
DynMethods.builder("register").impl(classToRegister).buildStaticChecked().invoke();
- } catch (NoSuchMethodException e) {
+ } catch (NoSuchMethodException | NoClassDefFoundError |
ExceptionInInitializerError e) {
Review Comment:
Note that callers must still handle invoke-time failures, hence why I'm
adding it here and in `InternalData`. I've also added tests to `TestDynMethods`
that verify this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
