rdblue commented on code in PR #16611:
URL: https://github.com/apache/iceberg/pull/16611#discussion_r3374663075
##########
common/src/main/java/org/apache/iceberg/common/DynConstructors.java:
##########
@@ -144,7 +144,7 @@ public Builder impl(String className, Class<?>... types) {
try {
Class<?> targetClass = classForName(className);
impl(targetClass, types);
- } catch (NoClassDefFoundError | ClassNotFoundException e) {
+ } catch (NoClassDefFoundError | ClassNotFoundException |
ExceptionInInitializerError e) {
Review Comment:
Please remove changes to this class. I don't think that this is necessary to
fix the bug and this is an over-broad change to the contract of our reflection
classes that are used in a lot of places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
