pvary commented on code in PR #16611:
URL: https://github.com/apache/iceberg/pull/16611#discussion_r3380939836
##########
core/src/test/java/org/apache/iceberg/formats/TestFormatModelRegistry.java:
##########
@@ -86,6 +88,77 @@ void testFailingReRegistrations() {
.hasMessageContaining("Cannot register class");
}
+ @Test
+ void registerDoesNotFailWhenClassThrowsNoClassDefFoundOnInvoke() {
Review Comment:
These tests are a bit awkward, and hard to understand what they are actually
test. Shall we create a package private `classesToRegister()` method and
override it in the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
