pvary commented on code in PR #16611:
URL: https://github.com/apache/iceberg/pull/16611#discussion_r3386976971


##########
core/src/test/java/org/apache/iceberg/formats/TestFormatModelRegistry.java:
##########
@@ -86,6 +88,77 @@ void testFailingReRegistrations() {
         .hasMessageContaining("Cannot register class");
   }
 
+  @Test
+  void registerDoesNotFailWhenClassThrowsNoClassDefFoundOnInvoke() {

Review Comment:
   What if we create a 'register(String)' method both in InternalData and 
FormatModelRegistry?
   We can call this from the prouction code and from the test too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to