Revanth14 opened a new pull request, #1141: URL: https://github.com/apache/iceberg-go/pull/1141
Fixes #941 ## Summary - Support the `s3.connect-timeout` property for S3 clients. - Accept PyIceberg-compatible numeric seconds such as `60` and `60.0`, plus Go duration strings such as `5s`. - Apply the value to the AWS SDK buildable client's dialer timeout. - Compose connect timeout with `s3.proxy-uri` by sharing the same buildable HTTP client. - Reject zero and negative timeout values with a clear error. Supersedes #950 and addresses all three items from laskoviymishka's review: float-seconds parsing, zero/negative rejection, and proxy+timeout composition test. ## Testing - `go test ./io/gocloud/...` ## Release note S3 now supports the `s3.connect-timeout` property, accepting numeric seconds like `60`/`60.0` and Go duration strings like `5s`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
