Revanth14 commented on code in PR #1141:
URL: https://github.com/apache/iceberg-go/pull/1141#discussion_r3330712541
##########
io/gocloud/s3.go:
##########
@@ -83,14 +73,32 @@ func ParseAWSConfig(ctx context.Context, props
map[string]string) (*aws.Config,
if proxy, ok := props[io.S3ProxyURI]; ok {
proxyURL, err := url.Parse(proxy)
if err != nil {
- return nil, fmt.Errorf("invalid s3 proxy url '%s'",
proxy)
+ return nil, fmt.Errorf("invalid s3 proxy url %q: %w",
proxy, err)
}
- opts = append(opts,
config.WithHTTPClient(awshttp.NewBuildableClient().WithTransportOptions(
+ httpClient = awshttp.NewBuildableClient().WithTransportOptions(
func(t *http.Transport) {
t.Proxy = http.ProxyURL(proxyURL)
},
- )))
+ )
+ }
+
+ if timeout, ok := props[io.S3ConnectTimeout]; ok {
+ duration, err := parseS3ConnectTimeout(timeout)
+ if err != nil {
+ return nil, err
+ }
+
+ if httpClient == nil {
+ httpClient = awshttp.NewBuildableClient()
Review Comment:
Thanks for flagging this. Since the same behavior already exists for
`s3.proxy-uri`, I opened a follow-up issue to track the shared transport-tuning
cleanup: #1148 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
