Revanth14 commented on code in PR #1141:
URL: https://github.com/apache/iceberg-go/pull/1141#discussion_r3329352069
##########
io/gocloud/s3_test.go:
##########
@@ -80,13 +84,111 @@ func TestParseAWSConfigRemoteSigningEnabled(t *testing.T) {
})
}
-func TestParseAWSConfigUnsupportedProperty(t *testing.T) {
+func TestParseAWSConfigInvalidConnectTimeout(t *testing.T) {
t.Parallel()
_, err := ParseAWSConfig(context.Background(), map[string]string{
- io.S3ConnectTimeout: "5000",
+ io.S3Region: "us-east-1",
+ io.S3ConnectTimeout: "not-a-duration",
})
- require.ErrorContains(t, err, "unsupported S3 property")
+ require.ErrorContains(t, err, "invalid s3.connect-timeout")
+}
+
+func TestParseAWSConfigConnectTimeout(t *testing.T) {
Review Comment:
Good point, thanks. Added a true fractional seconds case with `1.5`
expecting `1500 * time.Millisecond`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
