Revanth14 commented on code in PR #1141:
URL: https://github.com/apache/iceberg-go/pull/1141#discussion_r3329352677
##########
io/gocloud/s3.go:
##########
@@ -103,6 +111,27 @@ func ParseAWSConfig(ctx context.Context, props
map[string]string) (*aws.Config,
return awscfg, nil
}
+func parseS3ConnectTimeout(timeout string) (time.Duration, error) {
Review Comment:
Thanks, updated `parseS3ConnectTimeout` to parse into a single `duration`
variable and perform the positive-duration validation once at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
