joyhaldar commented on code in PR #16638:
URL: https://github.com/apache/iceberg/pull/16638#discussion_r3338525544
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -141,6 +145,39 @@ protected boolean supportsBatchReads() {
.map(generator -> Arguments.of(format, generator)))
.toList();
+ private static final List<Arguments> PRIMITIVE_TYPES_AND_DEFAULTS =
Review Comment:
The matrix is `(type, default-literal)` pairs and the test asserts the
reader injects exactly that literal, so the type has to stay paired with its
expected value. `DataGenerator` is one `schema() + random rows`, so it can't
carry that pairing, at least as I understand the current interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
