joyhaldar commented on code in PR #16638:
URL: https://github.com/apache/iceberg/pull/16638#discussion_r3353221500
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -141,6 +145,39 @@ protected boolean supportsBatchReads() {
.map(generator -> Arguments.of(format, generator)))
.toList();
+ private static final List<Arguments> PRIMITIVE_TYPES_AND_DEFAULTS =
Review Comment:
Added `DataGenerators.PrimitiveDefaults` and two tests,
`testPrimitiveDefaultValues` writes only id so the defaulted columns are absent
and the reader injects the defaults, `testPrimitiveDefaultValuesNotApplied`
writes random values into all columns and checks the round trip.
I replaced the old `testReaderSchemaEvolutionNewColumnWithDefault` + `the
type and default matrix`, which I removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
