pvary commented on code in PR #16638:
URL: https://github.com/apache/iceberg/pull/16638#discussion_r3339799586
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -141,6 +145,39 @@ protected boolean supportsBatchReads() {
.map(generator -> Arguments.of(format, generator)))
.toList();
+ private static final List<Arguments> PRIMITIVE_TYPES_AND_DEFAULTS =
Review Comment:
Can we create a generator with a schema with default values, and create 2
tests, one with nulls where we check for the default values, and one with
random data (not nulls), and check for the generated data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
