joyhaldar commented on code in PR #16638:
URL: https://github.com/apache/iceberg/pull/16638#discussion_r3356556229
##########
data/src/test/java/org/apache/iceberg/data/DataGenerators.java:
##########
@@ -89,4 +95,67 @@ public Schema schema() {
return schema;
}
}
+
+ // Generator for reader default-value tests across primitive types. TIME and
FIXED are left out
+ // because they fail on the engine read path, not because of default-value
handling.
+ // TODO: include TIME once the engine readers support it.
+ // TODO: include FIXED once Spark supports it.
Review Comment:
So for `TIME` there's #16665 and #15795 (adds the `supportsTime()` hook).
And `FIXED` doesn't have a fix yet.
Should we wait for those two to land and build on them, or ship this PR with
`TODOs` for now (i am fine with waiting)? I could look into the `FIXED` issue
in the meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
