pvary commented on code in PR #16638:
URL: https://github.com/apache/iceberg/pull/16638#discussion_r3355334240
##########
data/src/test/java/org/apache/iceberg/data/DataGenerators.java:
##########
@@ -89,4 +95,67 @@ public Schema schema() {
return schema;
}
}
+
+ // Generator for reader default-value tests across primitive types. TIME and
FIXED are left out
+ // because they fail on the engine read path, not because of default-value
handling.
+ // TODO: include TIME once the engine readers support it.
+ // TODO: include FIXED once Spark supports it.
Review Comment:
> TIME: works on Flink; fails on Spark,
java.lang.UnsupportedOperationException: Unsupported logical type: TIME_MICROS.
Maybe #16665 could be interesting here. We plan to use supportsTime for this
in the meantime which could be overridden by `TestSparkFormatModel`
> FIXED: works on Flink; fails on Spark,java.lang.ClassCastException: class
[B cannot be cast to class java.nio.ByteBuffer.
Is it a bug? Maybe a separate PR could be good where we discuss what is the
expected behavior. In the meantime we can add a TODO.
This is also highlighted in #15795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
