joyhaldar commented on code in PR #16638:
URL: https://github.com/apache/iceberg/pull/16638#discussion_r3355234042
##########
data/src/test/java/org/apache/iceberg/data/DataGenerators.java:
##########
@@ -89,4 +95,67 @@ public Schema schema() {
return schema;
}
}
+
+ // Generator for reader default-value tests across primitive types. TIME and
FIXED are left out
+ // because they fail on the engine read path, not because of default-value
handling.
+ // TODO: include TIME once the engine readers support it.
+ // TODO: include FIXED once Spark supports it.
Review Comment:
**TIME**: works on `Flink`; fails on `Spark`,
`java.lang.UnsupportedOperationException: Unsupported logical type:
TIME_MICROS`.
**FIXED**: works on `Flink`; fails on `Spark`,`java.lang.ClassCastException:
class [B cannot be cast to class java.nio.ByteBuffer`.
Since both work on `Flink` and only `Spark` fails, including them would mean
running on `Flink` but skipping on `Spark`. I'm not sure of the best way to
gate that per-engine here, open to suggestions.
Or we could keep both excluded and just update the `TODO` to note it's
`Spark` specific, or I could look into the `Spark` side `TIME` and `FIXED`
handling to see if it can be fixed, though I'm not familiar with those code
paths yet and would need to dig in (which I don't mind).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
