pvary commented on code in PR #16638:
URL: https://github.com/apache/iceberg/pull/16638#discussion_r3356835162
##########
data/src/test/java/org/apache/iceberg/data/DataGenerators.java:
##########
@@ -89,4 +95,67 @@ public Schema schema() {
return schema;
}
}
+
+ // Generator for reader default-value tests across primitive types. TIME and
FIXED are left out
+ // because they fail on the engine read path, not because of default-value
handling.
+ // TODO: include TIME once the engine readers support it.
+ // TODO: include FIXED once Spark supports it.
Review Comment:
I wouldn't wait.
Add the same supportsTime method as defined in #15795 and the faster one
wins, the second one rebases 😄
Keep a TODO for the bytebuffer stuff. This is for default values, not the
primitive type tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
