gaborkaszab commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3362957426
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -143,6 +149,29 @@ Tracking build() {
replacedPositions);
}
+ /** Derives the output status from the source, the snapshot, and any
mutations. */
+ private EntryStatus deriveStatus() {
+ if (source == null) {
+ return EntryStatus.ADDED;
+ }
+
+ boolean sameSnapshot = source.snapshotId() != null && source.snapshotId()
== newSnapshotId;
Review Comment:
Just for my benefit: What is the use-case for the "sameSnapshot" case? I
figure that Tracking is created whenever we create a new TrackedFile. Not sure
I see, within the same snapshot where we want to change Tracking again (or
recreate the TrackedFile with different Tracking). I probably miss, how this
integrates into the big picture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
