anoopj commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3363329670
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -143,6 +149,29 @@ Tracking build() {
replacedPositions);
}
+ /** Derives the output status from the source, the snapshot, and any
mutations. */
+ private EntryStatus deriveStatus() {
+ if (source == null) {
+ return EntryStatus.ADDED;
+ }
+
+ boolean sameSnapshot = source.snapshotId() != null && source.snapshotId()
== newSnapshotId;
Review Comment:
The added/same snapshot is not a separate scope. This is for the use case we
discussed in #16408 where a a writer constructs an ADDED tracking and
pipelines a DV attach in the same commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
