rdblue commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3365237807
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -106,35 +109,38 @@ TrackingBuilder dvUpdated() {
deletedPositions == null && replacedPositions == null,
"Cannot mark DV updated on a manifest entry (deleted/replaced
positions are set)");
this.dvSnapshotId = newSnapshotId;
+ this.mutated = true;
return this;
}
TrackingBuilder deletedPositions(ByteBuffer positions) {
- Preconditions.checkState(
- status == EntryStatus.EXISTING, "Cannot set deleted positions on %s
entry", status);
+ Preconditions.checkState(source != null, "Cannot set deleted positions on
ADDED entry");
Review Comment:
The error message should agree with the check. In this case, I think the
check is better if you use `status == ADDED`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
