rdblue commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3365244261
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -74,29 +77,29 @@ static Tracking replaced(Tracking source, long
newSnapshotId) {
}
private TrackingBuilder(long newSnapshotId) {
- this.status = EntryStatus.ADDED;
Review Comment:
I think this should still use status rather than mutated and source. There's
no need to keep the source around instead of storing its snapshot ID
individually. And we don't want to make inferences like state is added when
source is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
