rdblue commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r3364774000
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -66,23 +89,61 @@ public static Catalog wrap(
@SuppressWarnings("checkstyle:VisibilityModifier")
protected final long expirationIntervalMillis;
+ @SuppressWarnings("checkstyle:VisibilityModifier")
+ protected long expireAfterWriteIntervalMillis;
+
@SuppressWarnings("checkstyle:VisibilityModifier")
protected final Cache<TableIdentifier, Table> tableCache;
- private CachingCatalog(Catalog catalog, boolean caseSensitive, long
expirationIntervalMillis) {
- this(catalog, caseSensitive, expirationIntervalMillis,
Ticker.systemTicker());
+ private CachingCatalog(
+ Catalog catalog,
+ boolean caseSensitive,
+ long expirationIntervalMillis,
+ long expireAfterWriteIntervalMillis) {
+ this(
+ catalog,
+ caseSensitive,
+ expirationIntervalMillis,
+ Ticker.systemTicker(),
+ expireAfterWriteIntervalMillis);
}
+ /**
+ * Caching Catalog
+ *
+ * @deprecated will be removed in 1.12.0; use {@link
#CachingCatalog(Catalog, boolean, long,
+ * Ticker, long)} instead.
+ */
+ @Deprecated
Review Comment:
When will this be removed? We include that information in a `@deprecated`
tag when deprecating methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
