rdblue commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r3364795079
##########
core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java:
##########
@@ -376,7 +376,7 @@ public void
testCachingCatalogRejectsExpirationIntervalOfZero() {
assertThatThrownBy(() -> TestableCachingCatalog.wrap(hadoopCatalog(),
Duration.ZERO, ticker))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage(
- "When cache.expiration-interval-ms is set to 0, the catalog cache
should be disabled. This indicates a bug.");
+ "When both cache.expiration-interval-ms and
cache.expiration.expire-after-write-interval-ms are set to 0, the catalog cache
should be disabled. This indicates a bug.");
Review Comment:
It should be either one set to 0 is a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
