rdblue commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r3364792875
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -56,15 +56,19 @@ private CatalogProperties() {}
* <ul>
* <li>Zero - Caching and cache expiration are both disabled
* <li>Negative Values - Cache expiration is turned off and entries expire
only on refresh etc
- * <li>Positive Values - Cache entries expire if not accessed via the
cache after this many
- * milliseconds
+ * <li>Positive Values - Cache entries expire this milliseconds based on
the cache expiration
+ * policy
* </ul>
*/
public static final String CACHE_EXPIRATION_INTERVAL_MS =
"cache.expiration-interval-ms";
public static final long CACHE_EXPIRATION_INTERVAL_MS_DEFAULT =
TimeUnit.SECONDS.toMillis(30);
public static final long CACHE_EXPIRATION_INTERVAL_MS_OFF = -1;
+ public static final String CACHE_EXPIRATION_EXPIRE_AFTER_WRITE_INTERVAL_MS =
+ "cache.expiration.expire-after-write-interval-ms";
+ public static final long
CACHE_EXPIRATION_EXPIRE_AFTER_WRITE_INTERVAL_MS_DEFAULT = 0;
Review Comment:
I don't think this is the right default. A default of 0 ms would mean that
entries expire immediately. Instead, use -1 as a sentinel value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
