rdblue commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r3364776478
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -52,12 +53,34 @@ public static Catalog wrap(Catalog catalog) {
}
public static Catalog wrap(Catalog catalog, long expirationIntervalMillis) {
- return wrap(catalog, true, expirationIntervalMillis);
+ return wrap(
+ catalog,
+ true,
+ expirationIntervalMillis,
+
CatalogProperties.CACHE_EXPIRATION_EXPIRE_AFTER_WRITE_INTERVAL_MS_DEFAULT);
+ }
+
+ public static Catalog wrap(
+ Catalog catalog, long expirationIntervalMillis, long
expireAfterWriteIntervalMillis) {
+ return wrap(catalog, true, expirationIntervalMillis,
expireAfterWriteIntervalMillis);
}
public static Catalog wrap(
Catalog catalog, boolean caseSensitive, long expirationIntervalMillis) {
- return new CachingCatalog(catalog, caseSensitive,
expirationIntervalMillis);
+ return wrap(
+ catalog,
+ caseSensitive,
+ expirationIntervalMillis,
+
CatalogProperties.CACHE_EXPIRATION_EXPIRE_AFTER_WRITE_INTERVAL_MS_DEFAULT);
+ }
+
+ public static Catalog wrap(
Review Comment:
Can you please deprecate older versions of these methods with when they will
be removed so that we don't accumulate more and more of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
