rdblue commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3365258521
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -143,6 +149,29 @@ Tracking build() {
replacedPositions);
}
+ /** Derives the output status from the source, the snapshot, and any
mutations. */
+ private EntryStatus deriveStatus() {
Review Comment:
I think that this should go back to updating status in the builder config
methods rather than this. The impulse to co-locate logic for entry status is
good, but I think it is more readable not to do this refactor. When
modifications are made, the status can be validated and updated inline. That's
simpler and more clear, in my opinion, rather than trying to detect what
happened in the configuration phase and produce the correct status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
