blcksrx commented on code in PR #14440:
URL: https://github.com/apache/iceberg/pull/14440#discussion_r3374085500
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -109,7 +109,8 @@ public FlinkCatalog(
CatalogLoader catalogLoader,
Map<String, String> catalogProps,
boolean cacheEnabled,
- long cacheExpirationIntervalMs) {
+ long cacheExpirationIntervalMs,
+ long cacheExpireAfterWriteIntervalMs) {
Review Comment:
I understand that 14 different files would be a challenge but the whole
point of PR is to address the issue exists on Spark/Flink.
Im fine to make it separate but Im getting different comments from
maintainers that Im clueless what should I do.
@moomindani Asked me here to wire it to spark:
https://github.com/apache/iceberg/pull/14440#issuecomment-4621071011
could you please clarify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]