stevenzwu commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3375083040
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -49,6 +49,9 @@ interface TrackedFile {
Types.NestedField FILE_SIZE_IN_BYTES =
Types.NestedField.required(
104, "file_size_in_bytes", Types.LongType.get(), "Total file size in
bytes");
+ Types.NestedField WRITER_FORMAT_VERSION =
+ Types.NestedField.required(
Review Comment:
I think we should discuss these two things together.
1) if we define the writer_format_version as `0` (for pre-v4) and `1` (for
v4) that arenot aligned with table versions, this can be a required field
2) if we define the writer_format_version as `4` and `null` for pre-v4, then
this has to be an optional field because we don't know the table version when
the leaf manifest files were written.
I will resolve my other comment to consolidate on this thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
