stevenzwu commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3376020995
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -49,6 +49,9 @@ interface TrackedFile {
Types.NestedField FILE_SIZE_IN_BYTES =
Types.NestedField.required(
104, "file_size_in_bytes", Types.LongType.get(), "Total file size in
bytes");
+ Types.NestedField WRITER_FORMAT_VERSION =
+ Types.NestedField.required(
Review Comment:
> If we made it optional, it basically makes it impossible for readers to
really know about the manifest version without poking at the schema / checking
k/v metadata.
We use null/optional for other new fields introduced in v2 and v3 (like
sequence number etc.). `null` or `0` carry the same semantic meaning.
I have some concern on introducing a new versioning semantic: `0` (for
pre-v4) and `1` (for v4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
