amogh-jahagirdar commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3376882060
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -49,6 +49,9 @@ interface TrackedFile {
Types.NestedField FILE_SIZE_IN_BYTES =
Types.NestedField.required(
104, "file_size_in_bytes", Types.LongType.get(), "Total file size in
bytes");
+ Types.NestedField WRITER_FORMAT_VERSION =
+ Types.NestedField.required(
Review Comment:
I think I see where the confusion is, there's 2 different aspects here. The
literal enum value for the versions and then the writer requirements. These are
separate and the enum ID space may be disjoint from the logical representation
but we certainly should aim for clarity here.
@stevenzwu The third option you're mentioning is what I was thinking when I
say it should be "required" on write.
The clearest thing to do for the enum is to just start V4 at enum 4. I think
it was a mistake on my original spec PR to just do 0 for PRE-V4 and 1 for V4;
we can definitely just start V4 at enum 4. It's clearer and it's not like we
need to be worried about burning 1-3 enums anyways because the actual logical
space of versions is PRE-V4, V4, 5 etc (the versioning system will never have
an explicit v1 v2 or v3).
So I think we're on the same page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
