amogh-jahagirdar commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3375145472
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -49,6 +49,9 @@ interface TrackedFile {
Types.NestedField FILE_SIZE_IN_BYTES =
Types.NestedField.required(
104, "file_size_in_bytes", Types.LongType.get(), "Total file size in
bytes");
+ Types.NestedField WRITER_FORMAT_VERSION =
+ Types.NestedField.required(
Review Comment:
Let me make sure the doc is up to date, but I think it's best for this to be
a required field. We always know if a manifest is `pre-v4` or if it's v4. On
upgrade, a writer would just need to write the existing leaf manifests with
pre-v4 in the root. I feel like there's no reason for it to not be required,
it's known by writers and easy to determine and at the storage level it's going
to have very little footprint . If we made it optional, it basically makes it
impossible for readers to really know about the manifest version without poking
at the schema / checking k/v metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
